Skip to content

HYBIM-712 Removing Protect from Galileo sdk#42

Merged
shuningc merged 2 commits into
mainfrom
HYBIM-712-removeProtect
Jun 30, 2026
Merged

HYBIM-712 Removing Protect from Galileo sdk#42
shuningc merged 2 commits into
mainfrom
HYBIM-712-removeProtect

Conversation

@shuningc

Copy link
Copy Markdown
Contributor

Summary

Remove Protect from the splunk-ao SDK. Protect is being superseded by Agent Control and will be maintained only in the
galileo SDK for backward compatibility.

Changes

Files deleted:

  • src/splunk_ao/protect.py — Protect class, invoke_protect, ainvoke_protect
  • src/splunk_ao/stages.py — Stages class and create/get/update/pause/resume_protect_stage helper functions
  • src/splunk_ao/constants/protect.py — TIMEOUT_SECS constant
  • src/splunk_ao/handlers/langchain/tool.py — ProtectTool, ProtectParser, ProtectToolInputSchema
  • tests/test_protect.py, tests/test_protect_parser.py, tests/test_stages.py — all Protect-related tests

Files modified:

  • src/splunk_ao/init.py — removed all Protect imports and public exports (invoke_protect, ainvoke_protect,
    create/get/update/pause/resume_protect_stage, Payload, Ruleset, Request, Response, ExecutionStatus, StageType)
  • src/splunk_ao/logger/logger.py — removed add_protect_span method and its Payload/Response imports
  • tests/test_logger_batch.py, tests/test_logger_distributed.py — removed add_protect_span usage and protect span assertions
  • tests/conftest.py — removed rulesets fixture and Rule/Ruleset/RuleOperator imports

Impact

  • No impact on existing SDK functionality (logging, tracing, agent control, experiments, datasets) — 1660 tests pass
  • Breaking change for any callers using Protect APIs directly via splunk-ao; they should migrate to Agent Control or import
    Protect from the galileo package directly

@shuningc shuningc marked this pull request as draft June 24, 2026 23:57
@shuningc shuningc marked this pull request as ready for review June 25, 2026 19:30
@shuningc shuningc requested a review from fercor-cisco June 30, 2026 19:33

@fercor-cisco fercor-cisco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 This review was generated by the Astra agent (claude-opus-4-8). It may contain mistakes.

Verdict: approve — Clean, complete removal of the Protect feature; no dangling references to deleted symbols and test re-indexing is internally consistent.

@shuningc shuningc merged commit 66fcccd into main Jun 30, 2026
13 checks passed
@shuningc shuningc deleted the HYBIM-712-removeProtect branch June 30, 2026 22:38
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants